Fix #217, add handler for bplib_os_get_dtntime_ms #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a simple handler to translate the 32-bit return value into 64 bits. Of course this reduces the possible range, but should be good enough for the vast majority of coverage testing.
jphickey
added
ccb:provisionally-approved
|
Reviewed and provisionally approved at 2022-11-30 CCB, needs independent review before merge. |
glan6388
approved these changes
Nov 30, 2022
|
PR has been reviewed, ready to move from Provisional Approval to full Approval. |
jphickey
added
ccb:approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Implements a simple handler to translate the 32-bit return value into 64 bits. Of course this reduces the possible range, but should be good enough for the vast majority of coverage testing.
Fixes #217
Testing performed
Build and run all tests (including new/unmerged mpool test cases)
Expected behavior changes
The stub for
bplib_os_get_dtntime_ms()does not throw an error when used in default configuration.System(s) tested on
Ubuntu
Additional context
This only matters for test cases that need to call this stub function.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.